Refactor atom input component 1 #2449
Open
+1,437
−1,094
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…he nes input structure
andresin87
changed the base branch from
refactor-atom-input-component
to
master
|
andresin87
commented
May 8, 2023
| @@ -11,7 +11,7 @@ | |||
| "dependencies": { | |||
| "@s-ui/react-hooks": "1", | |||
| "@s-ui/react-primitive-polymorphic-element": "1", | |||
| "imask": "3.4.0" | |||
| "react-imask": "6.4.3" | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Atom/Input
❓ AskTASK:
Types of changes
Description, Motivation and Context
The current AtomInput structure is giving problems with refs due to its HTML structure.
It also takes lots of improvements:
Screenshots - Animations
🚨🚨🚨🚨🚨🚨
This PR will remain iddle untill 1 person per vertical reviews its demo l&f and approves it at least.
Components which use @s-ui/react-atom-input or needs a review:
Mark on each component when reviewing your branded components or just one mark at the end if everything is ok to confirm all the component changes:
TEST on your vertical (if needed) installing: